Skip to content

Commit

Permalink
Bump the bundler-lint group with 5 updates (#1533)
Browse files Browse the repository at this point in the history
* Bump the bundler-lint group with 5 updates

Bumps the bundler-lint group with 5 updates:

| Package | From | To |
| --- | --- | --- |
| [brakeman](https://github.com/presidentbeef/brakeman) | `6.2.1` | `6.2.2` |
| [erb_lint](https://github.com/Shopify/erb-lint) | `0.6.0` | `0.7.0` |
| [rubocop](https://github.com/rubocop/rubocop) | `1.65.0` | `1.68.0` |
| [rubocop-rails](https://github.com/rubocop/rubocop-rails) | `2.26.2` | `2.27.0` |
| [rubocop-rspec](https://github.com/rubocop/rubocop-rspec) | `3.1.0` | `3.2.0` |


Updates `brakeman` from 6.2.1 to 6.2.2
- [Release notes](https://github.com/presidentbeef/brakeman/releases)
- [Changelog](https://github.com/presidentbeef/brakeman/blob/main/CHANGES.md)
- [Commits](presidentbeef/brakeman@v6.2.1...v6.2.2)

Updates `erb_lint` from 0.6.0 to 0.7.0
- [Release notes](https://github.com/Shopify/erb-lint/releases)
- [Commits](Shopify/erb_lint@v0.6.0...v0.7.0)

Updates `rubocop` from 1.65.0 to 1.68.0
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v1.65.0...v1.68.0)

Updates `rubocop-rails` from 2.26.2 to 2.27.0
- [Release notes](https://github.com/rubocop/rubocop-rails/releases)
- [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop-rails@v2.26.2...v2.27.0)

Updates `rubocop-rspec` from 3.1.0 to 3.2.0
- [Release notes](https://github.com/rubocop/rubocop-rspec/releases)
- [Changelog](https://github.com/rubocop/rubocop-rspec/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop-rspec@v3.1.0...v3.2.0)

---
updated-dependencies:
- dependency-name: brakeman
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: bundler-lint
- dependency-name: erb_lint
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: bundler-lint
- dependency-name: rubocop
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: bundler-lint
- dependency-name: rubocop-rails
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: bundler-lint
- dependency-name: rubocop-rspec
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: bundler-lint
...

Signed-off-by: dependabot[bot] <[email protected]>

* Fix linter errors

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ben Sheldon [he/him] <[email protected]>
  • Loading branch information
dependabot[bot] and bensheldon authored Nov 10, 2024
1 parent 7b3f8ba commit f215f39
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 14 deletions.
21 changes: 10 additions & 11 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ GEM
bigdecimal (3.1.8-java)
bootsnap (1.18.4)
msgpack (~> 1.2)
brakeman (6.2.1)
brakeman (6.2.2)
racc
builder (3.3.0)
capybara (3.40.0)
Expand Down Expand Up @@ -167,7 +167,7 @@ GEM
easy_translate (0.5.1)
thread
thread_safe
erb_lint (0.6.0)
erb_lint (0.7.0)
activesupport
better_html (>= 2.0.1)
parser (>= 2.7.1.4)
Expand Down Expand Up @@ -232,8 +232,8 @@ GEM
reline (>= 0.4.2)
jar-dependencies (0.4.1)
jdbc-postgres (42.6.0)
json (2.7.2)
json (2.7.2-java)
json (2.7.5)
json (2.7.5-java)
kramdown (2.4.0)
rexml
kramdown-parser-gfm (1.1.0)
Expand Down Expand Up @@ -295,7 +295,7 @@ GEM
sawyer (~> 0.9)
optimist (3.1.0)
parallel (1.26.3)
parser (3.3.5.0)
parser (3.3.5.1)
ast (~> 2.4.1)
racc
pg (1.5.9)
Expand Down Expand Up @@ -393,30 +393,29 @@ GEM
rspec-mocks (~> 3.13)
rspec-support (~> 3.13)
rspec-support (3.13.1)
rubocop (1.65.0)
rubocop (1.68.0)
json (~> 2.3)
language_server-protocol (>= 3.17.0)
parallel (~> 1.10)
parser (>= 3.3.0.2)
rainbow (>= 2.2.2, < 4.0)
regexp_parser (>= 2.4, < 3.0)
rexml (>= 3.2.5, < 4.0)
rubocop-ast (>= 1.31.1, < 2.0)
rubocop-ast (>= 1.32.2, < 2.0)
ruby-progressbar (~> 1.7)
unicode-display_width (>= 2.4.0, < 3.0)
rubocop-ast (1.32.3)
rubocop-ast (1.33.0)
parser (>= 3.3.1.0)
rubocop-capybara (2.21.0)
rubocop (~> 1.41)
rubocop-performance (1.22.1)
rubocop (>= 1.48.1, < 2.0)
rubocop-ast (>= 1.31.1, < 2.0)
rubocop-rails (2.26.2)
rubocop-rails (2.27.0)
activesupport (>= 4.2.0)
rack (>= 1.1)
rubocop (>= 1.52.0, < 2.0)
rubocop-ast (>= 1.31.1, < 2.0)
rubocop-rspec (3.1.0)
rubocop-rspec (3.2.0)
rubocop (~> 1.61)
rubocop-rspec_rails (2.30.0)
rubocop (~> 1.61)
Expand Down
2 changes: 1 addition & 1 deletion lib/good_job/capsule_tracker.rb
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ def renew(silent: false)
# Tests whether an active advisory lock has been taken on the record.
# @return [Boolean]
def advisory_locked?
@advisory_locked_connection&.weakref_alive? && @advisory_locked_connection&.active?
@advisory_locked_connection&.weakref_alive? && @advisory_locked_connection.active?
end

# @!visibility private
Expand Down
2 changes: 0 additions & 2 deletions spec/app/models/good_job/job_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -732,8 +732,6 @@ def job_params
next if rescue_with_handler(e)

raise e
ensure
nil
end
end

Expand Down

0 comments on commit f215f39

Please sign in to comment.