Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies for PureScript 0.15.9 #4

Merged
merged 2 commits into from
Jun 26, 2023

Conversation

stephen-smith
Copy link
Contributor

Passed all tests I could fine in the repo. ;)

@benjamin-hodgson
Copy link
Owner

Thank you very much! I'm merging this but I need to (re)learn how to publish Purescript packages. So might take a little while to get this up on the registry

@benjamin-hodgson benjamin-hodgson merged commit 8de1f33 into benjamin-hodgson:master Jun 26, 2023
@benjamin-hodgson
Copy link
Owner

Did this but looks like it hasn't been picked up yet, I'll check back tomorrow maybe purescript/registry#302

@benjamin-hodgson
Copy link
Owner

I should also set up a CI workflow and some tests, probably

@stephen-smith
Copy link
Contributor Author

Did this but looks like it hasn't been picked up yet, I'll check back tomorrow maybe purescript/registry#302

I think SemVer requires a MAJOR version change (so, v1.0.0 instead of v0.6.0), since some of the type class instances were "removed": their requirements/context changed, so they might not be available at some types where they were previously available. But, at this point, I don't see practical advantages to a version bump.

@benjamin-hodgson
Copy link
Owner

I guess that's true. Ah well. I think it's unlikely to matter, haha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants