This repository has been archived by the owner on Nov 18, 2022. It is now read-only.
Fix for roster bug + small maintenance for 2021 season #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix load roster bug: bendominguez0111#2 load_roster_data() now accepts 1 int (year/season) argument, defaulting to 2021.
First commit for new method nflfastpy.aggregate_stats() Input: pbp df Output: df w/ aggregated and calculated stats derived from pbp. For now, aggregated at the team level. This first commit successfully returns aggregated passing (QB) statistics.
-Added rushing stats to aggregation, aggregate_stats() now returns rushing stats per team -Added counters for l/m/r for rush_direction and g/t/e for rush_gap -TODO: refactoring the above - TODO: add some additional rushing calculations (after all aggregation) - TODO: Merge passing + rushing df And now it's time for Ted Lasso.
- added v1 aggregated receiving stats - nflfastpy.aggregate_stats() now returns 3 df's: passing, rushing, and receiving stats by team (TODO: merge these) - replaced ROSTER_URL per bendominguez0111#2 (comment). nflfastpy.load_roster_data()'s parameters still include a season, but default to 2021 if no value is provided. load_roster_data() returns a dataframe for 1 season only.
- Added some counters for two point attempts, passes, rushes, as well as counters when they succeed - aggregate_stats() now returns 4 df's (passing, rushing, receiving, two pointers)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the reported load roster bug:
#2
load_roster_data() now explicitly accepts 1 int (year/season) argument, defaulting to 2021.