Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RESULTS upload fmralign_benchopt/benchopt_run_2023-07-05_12h16m30.parquet #35

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

man-shu
Copy link

@man-shu man-shu commented Jul 5, 2023

Loading result file for benchmark fmralign_benchopt.

@@ -0,0 +1 @@
{"pretty_name": "frmalign-benchopt"}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you provide a nicer name for the benchmark? 😁 as is, it is hard to know what it is about.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, it was actually supposed to be fmralign-benchopt not frmalign-benchopt. We'll fix and improve that. Thanks!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is brain-alignment-benchopt clearer ?

Copy link
Member

@tomMoral tomMoral Jul 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the name that will appear on the front page of the results so you should be explicit.

I would say putting fMRI alignment or Brain MRI alignment is nice, without the bemchopt and the hyphen?

Note that this should be set as a name attribute in the Objective class.

@man-shu
Copy link
Author

man-shu commented Jul 6, 2023

@pbarbarant added more solvers to the benchmark. Is there a way to add those too? Do we just need to push the parquet with all of them?

@tomMoral
Copy link
Member

Yes you can simply push the parquet. I think if you do a second benchopt publish --file filename this should update this PR. if it does not, feel free to report what's happening, so we can improve the behavior 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants