Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/catch multiline benchmarks #46

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bernedom
Copy link
Contributor

If Benchmark names are too long, catch wraps them which caused the github action to fail.
Adapted the regex to accommodate for this case.

spl pushed a commit to terminusdb-labs/benchmark-tracker that referenced this pull request Aug 5, 2021
@ghost
Copy link

ghost commented Feb 3, 2022

I encountered the same issue, would be great to get this merged and released.

As a workaround we can add #define CATCH_CONFIG_CONSOLE_WIDTH 200 (or any width needed) in the benchmark source to overwrite catch2's default output width of 80 characters to prevent long benchmark names wrapping.

@bernedom
Copy link
Contributor Author

bernedom commented Feb 6, 2022

As a workaround we can add #define CATCH_CONFIG_CONSOLE_WIDTH 200 (or any width needed) in the benchmark source to overwrite catch2's default output width of 80 characters to prevent long benchmark names wrapping.

That's actually a quite decend workaround until this is merged. Did not know that catch allows to configure this.

@wwerkk
Copy link

wwerkk commented Mar 22, 2024

Any updates on this PR?
Unless I am missing something, overwriting the width doesn't seem to be an option if Catch2 is fetched with CMake

@wwerkk
Copy link

wwerkk commented Mar 28, 2024

Any updates on this PR? Unless I am missing something, overwriting the width doesn't seem to be an option if Catch2 is fetched with CMake

solved the problem by adding set(CATCH_CONFIG_CONSOLE_WIDTH 200) before fetching Catch2 in CMakeLists.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants