fix: Support sub-nanosecond precision on Cargo benchmarks

CHANGELOG.md

@@ -1,4 +1,6 @@
 ## Unreleased
+- **fix** Support sub-nanosecond precision on Cargo benchmarks (#246)
+
 
 <a name="v1.20.1"></a>
 # [v1.20.1](https://github.com/benchmark-action/github-action-benchmark/releases/tag/v1.20.1) - 02 Apr 2024

src/extract.ts

@@ -29,7 +29,7 @@
 }
 
 interface PullRequest {
     [key: string]: any;
     number: number;
     html_url?: string;
     body?: string;
@@ -314,8 +314,8 @@
     const lines = output.split(/\r?\n/g);
     const ret = [];
     // Example:
-    //   test bench_fib_20 ... bench:      37,174 ns/iter (+/- 7,527)
-    const reExtract = /^test (.+)\s+\.\.\. bench:\s+([0-9,]+) ns\/iter \(\+\/- ([0-9,]+)\)$/;
+    //   test bench_fib_20 ... bench:      37,174.25 ns/iter (+/- 7,527.43)
+    const reExtract = /^test (.+)\s+\.\.\. bench:\s+([0-9,.]+) ns\/iter \(\+\/- ([0-9,.]+)\)$/;
     const reComma = /,/g;
 
     for (const line of lines) {
@@ -325,7 +325,7 @@
         }
 
         const name = m[1].trim();
-        const value = parseInt(m[2].replace(reComma, ''), 10);
+        const value = parseFloat(m[2].replace(reComma, ''));
         const range = m[3].replace(reComma, '');
 
         ret.push({
@@ -437,7 +437,7 @@
             const extra = `mean: ${mean} ${meanUnit}\nrounds: ${stats.rounds}`;
             return { name, value, unit, range, extra };
         });
     } catch (err: any) {
         throw new Error(
             `Output file for 'pytest' must be JSON file generated by --benchmark-json option: ${err.message}`,
         );
@@ -448,7 +448,7 @@
     let json: GoogleCppBenchmarkJson;
     try {
         json = JSON.parse(output);
     } catch (err: any) {
         throw new Error(
             `Output file for 'googlecpp' must be JSON file generated by --benchmark_format=json option: ${err.message}`,
         );
@@ -576,7 +576,7 @@
     return ret;
 }
 
 function extractJuliaBenchmarkHelper([_, bench]: JuliaBenchmarkGroup, labels: string[] = []): BenchmarkResult[] {
     const res: BenchmarkResult[] = [];
     for (const key in bench.data) {
         const value = bench.data[key];
@@ -607,7 +607,7 @@
     let json: JuliaBenchmarkJson;
     try {
         json = JSON.parse(output);
     } catch (err: any) {
         throw new Error(
             `Output file for 'julia' must be JSON file generated by BenchmarkTools.save("output.json", suit::BenchmarkGroup) :  ${err.message}`,
         );
@@ -625,7 +625,7 @@
     let json: JmhBenchmarkJson[];
     try {
         json = JSON.parse(output);
     } catch (err: any) {
         throw new Error(`Output file for 'jmh' must be JSON file generated by -rf json option: ${err.message}`);
     }
     return json.map((b) => {
@@ -642,7 +642,7 @@
     let json: BenchmarkDotNetBenchmarkJson;
     try {
         json = JSON.parse(output);
     } catch (err: any) {
         throw new Error(
             `Output file for 'benchmarkdotnet' must be JSON file generated by '--exporters json' option or by adding the JsonExporter to your run config: ${err.message}`,
         );
@@ -663,7 +663,7 @@
         return json.map(({ name, value, unit, range, extra }) => {
             return { name, value, unit, range, extra };
         });
     } catch (err: any) {
         throw new Error(
             `Output file for 'custom-(bigger|smaller)-is-better' must be JSON file containing an array of entries in BenchmarkResult format: ${err.message}`,
         );

test/__snapshots__/extract.spec.ts.snap

@@ -175,6 +175,35 @@ exports[`extractResult() extracts benchmark output from cargo - cargo_output2.tx
 }
 `;
 
+exports[`extractResult() extracts benchmark output from cargo - cargo_output3.txt 1`] = `
+{
+  "benches": [
+    {
+      "name": "bench_fib_10",
+      "range": "± 2.21",
+      "unit": "ns/iter",
+      "value": 148.7,
+    },
+    {
+      "name": "bench_fib_20",
+      "range": "± 440.25",
+      "unit": "ns/iter",
+      "value": 18794.12,
+    },
+  ],
+  "commit": {
+    "author": null,
+    "committer": null,
+    "id": "123456789abcdef",
+    "message": "this is dummy",
+    "timestamp": "dummy timestamp",
+    "url": "https://github.com/dummy/repo",
+  },
+  "date": 1712131503296,
+  "tool": "cargo",
+}
+`;
+
 exports[`extractResult() extracts benchmark output from cargo - criterion_output.txt 1`] = `
 {
   "benches": [

test/data/extract/cargo_output3.txt

@@ -0,0 +1,12 @@
+
+running 0 tests
+
+test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out
+
+
+running 2 tests
+test bench_fib_10 ... bench:         148.70 ns/iter (+/- 2.21)
+test bench_fib_20 ... bench:      18,794.12 ns/iter (+/- 440.25)
+
+test result: ok. 0 passed; 0 failed; 0 ignored; 2 measured; 0 filtered out
+

test/extract.spec.ts

@@ -67,6 +67,10 @@ describe('extractResult()', function () {
             tool: 'cargo',
             file: 'cargo_output2.txt',
         },
+        {
+            tool: 'cargo',
+            file: 'cargo_output3.txt',
+        },
         {
             tool: 'cargo',
             file: 'criterion_output.txt',