Don't fail if benchmark performs better irrespective of threshold config #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There might be situations if the changes drastically improves the performance or the thresholds are configured with lower values it lead to failure of the action whereas it is not. i.e if the alert and failure threshold are configured as 0.1 and 0.2 and the previous and current values are bigger, then the existing check would consider it as failure So added a check to ensure the failure is calculated based on the performance and threshold rather than threshold alone
michaelmior
reviewed
Sep 22, 2022
Comment on lines
+304
to
+307
| //Only consider it as failure if the benchmark performed better irrespective of the alert threshold | ||
| // For ex if there is a massive performance improvement between commits | ||
| // or the alert threshold and failure threshold is lower the failure might be triggered. | ||
| // This check ensures that the check is failure only if the performance is not better |
There was a problem hiding this comment.
This comment is difficult to read. It starts with "Only consider it as failure if the benchmark performed better…" Isn't the purpose of this change not to fail if the benchmark performs better?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There might be situations if the changes drastically improves the
performance or the thresholds are configured with lower values it lead
to failure of the action whereas it is not.
i.e if the alert and failure threshold are configured as 0.1 and 0.2 and
the previous and current values are bigger, then the existing check
would consider it as failure
So added a check to ensure the failure is calculated based on the
performance and threshold rather than threshold alone