Config refactor avoiding circular dep issues #485
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielmkm
requested changes
Oct 18, 2023
franzns
reviewed
Nov 3, 2023
franzns
reviewed
Nov 3, 2023
franzns
reviewed
Nov 3, 2023
modules/network/arbitrum/workers.ts
Outdated
| For every 1 days jobs we set the alarmEvaluationPeriod and alarmDatapointsToAlarm to 1 instead of the default 3. | ||
| This is needed because the maximum alarm evaluation period is 1 day (period * evaluationPeriod). | ||
| */ | ||
| export const arbitrumWorkerJobs = [ |
franzns
reviewed
Nov 3, 2023
| import { JsonRpcProvider } from '@ethersproject/providers'; | ||
| import { mainnetNetworkData as data } from './data'; | ||
| import { mainnetWorkerJobs as workerJobs } from './workers'; | ||
|
|
There was a problem hiding this comment.
actually it's not needed. i'm removing from other networks as well.
|
hey @danielmkm - i think all the changes are there, let me know if you want to get anything else updated. |
|
I'll close this PR for now, since it's not solving the underlying issue fully. The issue is related to the networkContext and we will be refactoring that for specific cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.