Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chains array param to user balance query #482

Merged
merged 6 commits into from
Oct 18, 2023

Conversation

danielmkm
Copy link
Contributor

@danielmkm danielmkm commented Oct 16, 2023

Add support for fetching user balances from multiple chains at once. As the balances leverage the token prices, we also implement support for multi chain token price fetching.

@danielmkm
Copy link
Contributor Author

danielmkm commented Oct 16, 2023

TODO: need to add support for fetching prices for multiple chains

@danielmkm danielmkm marked this pull request as draft October 16, 2023 15:40
@danielmkm danielmkm marked this pull request as ready for review October 17, 2023 04:33
@danielmkm danielmkm requested review from gmbronco and franzns October 17, 2023 04:34
Copy link
Contributor

@gmbronco gmbronco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm – i just added a small change making it default to all chains if no chains are provided and an address filter, might be slightly easier to query.

@danielmkm
Copy link
Contributor Author

lgtm – i just added a small change making it default to all chains if no chains are provided and an address filter, might be slightly easier to query.

Thanks for having a look @gmbronco. The way you did allChains will include fantom and optimism for balancer. You'd want to scope it to the project.

@gmbronco
Copy link
Contributor

we changed the default fallback to the chainId passed in the header, so it's backwards compatibile.

@gmbronco gmbronco merged commit 0b0b7ff into v3-canary Oct 18, 2023
1 check passed
@gmbronco gmbronco deleted the feature/add-chains-to-user-balance-query branch October 18, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants