Define the basis for a generic and customizable BalancerSdkConfig #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds upon balancer#20
The
BalancerSdkConfig
should serve as the basis for a global config object with the goal of providing both a simple way to create the SDK for standard usecases and the ability to customize and extend the SDK when necessary.For the standard usecase, you'll be able to create the SDK with only the network ID and an rpc url:
We leverage the flexibility of typescript types to allow for the definition of the
network
to be simply the chain id OR a fully defined network config.We provide the option to selectively overwrite data sources for the SOR. This should extend out into other parts of the SDK where applicable. Default config that is customisable where it makes sense.
Additionally in this PR: