Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor registration of commands #512

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Refactor registration of commands #512

merged 2 commits into from
Oct 9, 2024

Conversation

TheBurchLog
Copy link
Contributor

No description provided.

@TheBurchLog TheBurchLog requested a review from 1maple1 October 7, 2024 10:43
@TheBurchLog TheBurchLog marked this pull request as draft October 9, 2024 16:22
@TheBurchLog TheBurchLog marked this pull request as ready for review October 9, 2024 16:22
1maple1
1maple1 approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@1maple1 1maple1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Same functionality but now you can specify name or func as input. Serializer, too.

@TheBurchLog TheBurchLog merged commit 7e3aacb into develop Oct 9, 2024
6 checks passed
@TheBurchLog TheBurchLog deleted the topic_add_sub_patch branch October 9, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1maple1 1maple1 1maple1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheBurchLog @1maple1