Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parameter type when no type is specified #491

Merged
merged 5 commits into from
Jul 12, 2024
Merged

Conversation

1maple1
Copy link
Contributor

@1maple1 1maple1 commented Jul 11, 2024

If no type is specified, need to leave it alone so it matches the type hinting.

@1maple1 1maple1 requested a review from TheBurchLog July 11, 2024 11:27
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 15.12%. Comparing base (aecb6ee) to head (b9a93e1).
Report is 27 commits behind head on develop.

Files Patch % Lines
brewtils/decorators.py 0.00% 12 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #491      +/-   ##
===========================================
- Coverage    15.24%   15.12%   -0.12%     
===========================================
  Files           28       28              
  Lines         3930     3960      +30     
===========================================
  Hits           599      599              
- Misses        3331     3361      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheBurchLog TheBurchLog merged commit 4d1bcf9 into develop Jul 12, 2024
6 checks passed
@TheBurchLog TheBurchLog deleted the parameter-fix branch July 12, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants