Fix cross-server requests #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBurchLog
reviewed
May 13, 2024
brewtils/rest/system_client.py
Outdated
| ) | ||
| ec.put_request(request) | ||
| if request.parent is not None: | ||
| request.has_parent = True |
There was a problem hiding this comment.
I think we should upload the request regardless if there is a parent request. Because it could be created out of band from a traditional request and we still want to track that information. So we should do something like this:
request.has_parent = request.parent is not NoneThere was a problem hiding this comment.
Took a minute to understand how this was different - now a put request is run whether or nor there is a parent.
TheBurchLog
approved these changes
May 13, 2024
TheBurchLog
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.