Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed default check for "false" defaults #458

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Fixed default check for "false" defaults #458

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
Brewtils Changelog
==================

3.24.3
------
3/6/24

- Fixed bug where Self Referencing SystemClients did not support `false` as default value when not provided

3.24.2
------
3/1/24
Expand Down
2 changes: 1 addition & 1 deletion brewtils/request_handling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ def process_command(self, request):
command = _parse_method(getattr(brewtils.plugin.CLIENT, request.command, None))
if command:
for parameter in command.parameters:
if parameter.default:
if parameter.default is not None:
if parameter.key not in request.parameters:
request.parameters[parameter.key] = parameter.default

Expand Down
Loading