Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if Default instead of Is_Kwarg #453

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Check if Default instead of Is_Kwarg #453

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ Brewtils Changelog
------
TBD

- Self Referecing SystemClient now supports kwargs provided through the Parameter annotation
- Self Referencing SystemClient now supports default values provided through the Parameter annotation

3.24.0
------
Expand Down
2 changes: 1 addition & 1 deletion brewtils/request_handling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ def process_command(self, request):
for command in self._system.commands:
if command.name == request.command:
for parameter in command.parameters:
if parameter.is_kwarg:
if parameter.default:
if parameter.key not in request.parameters:
request.parameters[parameter.key] = parameter.default

Expand Down
Loading