Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New User Model #448

Merged
merged 59 commits into from
Jul 25, 2024
Merged

New User Model #448

merged 59 commits into from
Jul 25, 2024

Conversation

TheBurchLog
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: Patch coverage is 18.75000% with 78 lines in your changes missing coverage. Please review.

Project coverage is 15.39%. Comparing base (aecb6ee) to head (3503afd).
Report is 8 commits behind head on develop.

Current head 3503afd differs from pull request most recent head b78ee1f

Please upload reports for the commit b78ee1f to get more accurate results.

Files Patch % Lines
brewtils/models.py 36.73% 31 Missing ⚠️
brewtils/schemas.py 0.00% 29 Missing ⚠️
brewtils/schema_parser.py 0.00% 17 Missing ⚠️
brewtils/rest/easy_client.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #448      +/-   ##
===========================================
+ Coverage    15.24%   15.39%   +0.15%     
===========================================
  Files           28       28              
  Lines         3930     3924       -6     
===========================================
+ Hits           599      604       +5     
+ Misses        3331     3320      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheBurchLog TheBurchLog marked this pull request as draft February 21, 2024 16:23
@TheBurchLog TheBurchLog requested a review from 1maple1 June 19, 2024 10:25
@TheBurchLog TheBurchLog marked this pull request as ready for review June 19, 2024 12:53
@TheBurchLog TheBurchLog changed the title Draft: New User Model New User Model Jun 21, 2024
brewtils/models.py Outdated Show resolved Hide resolved
brewtils/models.py Outdated Show resolved Hide resolved
Copy link
Contributor

@1maple1 1maple1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor gripes so take a look when you can.

@TheBurchLog TheBurchLog changed the base branch from develop to 3.27.0_staged July 25, 2024 14:06
@TheBurchLog TheBurchLog merged commit 4bddb90 into 3.27.0_staged Jul 25, 2024
6 checks passed
@TheBurchLog TheBurchLog deleted the User_Model branch July 25, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants