Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default topic for PublishClient #432

Merged
merged 6 commits into from
Dec 13, 2023
Merged

Conversation

TheBurchLog
Copy link
Contributor

Adds a default topic of Namespace.System.Version.Instance for Publish Client

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Attention: 51 lines in your changes are missing coverage. Please review.

Comparison is base (95d48b6) 92.39% compared to head (68b684b) 14.37%.
Report is 11 commits behind head on develop.

❗ Current head 68b684b differs from pull request most recent head 86d3acd. Consider uploading reports for the commit 86d3acd to get more accurate results

Files Patch % Lines
brewtils/decorators.py 11.11% 16 Missing ⚠️
brewtils/models.py 20.00% 8 Missing ⚠️
brewtils/rest/publish_client.py 0.00% 6 Missing ⚠️
brewtils/plugin.py 16.66% 5 Missing ⚠️
brewtils/rest/client.py 0.00% 4 Missing ⚠️
brewtils/rest/easy_client.py 0.00% 4 Missing ⚠️
brewtils/rest/system_client.py 0.00% 3 Missing ⚠️
brewtils/schemas.py 0.00% 3 Missing ⚠️
brewtils/__init__.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #432       +/-   ##
============================================
- Coverage    92.39%   14.37%   -78.02%     
============================================
  Files           28       28               
  Lines         3644     3686       +42     
============================================
- Hits          3367      530     -2837     
- Misses         277     3156     +2879     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheBurchLog TheBurchLog merged commit 31fcc4e into develop Dec 13, 2023
6 checks passed
@TheBurchLog TheBurchLog deleted the DefaultPublishTopic branch December 13, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant