Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed subscribe topic bug #417

Merged
merged 6 commits into from
Nov 2, 2023
Merged

Fixed subscribe topic bug #417

merged 6 commits into from
Nov 2, 2023

Conversation

TheBurchLog
Copy link
Contributor

When using the topic variable, it would appear 3 times in the topic list.

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Attention: 81 lines in your changes are missing coverage. Please review.

Comparison is base (a738e1c) 94.26% compared to head (1c1e177) 92.39%.
Report is 10 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #417      +/-   ##
===========================================
- Coverage    94.26%   92.39%   -1.87%     
===========================================
  Files           26       28       +2     
  Lines         3452     3644     +192     
===========================================
+ Hits          3254     3367     +113     
- Misses         198      277      +79     
Files Coverage Δ
brewtils/__init__.py 81.25% <100.00%> (+2.67%) ⬆️
brewtils/__version__.py 100.00% <100.00%> (ø)
brewtils/models.py 90.36% <100.00%> (+0.04%) ⬆️
brewtils/rest/client.py 93.86% <100.00%> (+0.02%) ⬆️
brewtils/schemas.py 99.17% <100.00%> (+<0.01%) ⬆️
brewtils/plugin.py 96.27% <50.00%> (-0.27%) ⬇️
brewtils/rest/system_client.py 91.20% <44.44%> (-8.15%) ⬇️
brewtils/auto_decorator.py 23.80% <23.80%> (ø)
brewtils/rest/publish_client.py 32.00% <32.00%> (ø)
brewtils/decorators.py 86.92% <71.68%> (-9.02%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheBurchLog TheBurchLog merged commit 0e28b10 into develop Nov 2, 2023
7 of 8 checks passed
@TheBurchLog TheBurchLog deleted the SubscriberBug branch November 2, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant