Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed self reference loop #413

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Fixed self reference loop #413

merged 2 commits into from
Oct 30, 2023

Conversation

TheBurchLog
Copy link
Contributor

If a client was self referencing, then it would cause an infinite loop trying to find the current namespace counter, because it wasn't defined.

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Attention: 48 lines in your changes are missing coverage. Please review.

Comparison is base (a738e1c) 94.26% compared to head (4cea5e5) 93.14%.
Report is 6 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #413      +/-   ##
===========================================
- Coverage    94.26%   93.14%   -1.13%     
===========================================
  Files           26       27       +1     
  Lines         3452     3588     +136     
===========================================
+ Hits          3254     3342      +88     
- Misses         198      246      +48     
Files Coverage Δ
brewtils/__init__.py 80.00% <100.00%> (+1.42%) ⬆️
brewtils/__version__.py 100.00% <100.00%> (ø)
brewtils/rest/client.py 93.84% <100.00%> (ø)
brewtils/plugin.py 96.27% <50.00%> (-0.27%) ⬇️
brewtils/rest/system_client.py 92.48% <33.33%> (-6.87%) ⬇️
brewtils/auto_decorator.py 23.80% <23.80%> (ø)
brewtils/decorators.py 90.72% <80.61%> (-5.22%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheBurchLog TheBurchLog merged commit daee0e9 into develop Oct 30, 2023
6 of 7 checks passed
@TheBurchLog TheBurchLog deleted the Client_bug branch October 30, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant