Skip to content

Commit

Permalink
Merge branch 'develop' into command_display_name
Browse files Browse the repository at this point in the history
  • Loading branch information
1maple1 committed Dec 3, 2024
2 parents 31633d6 + aff3105 commit 86ac725
Show file tree
Hide file tree
Showing 8 changed files with 8 additions and 37 deletions.
4 changes: 3 additions & 1 deletion CHANGELOG.rst
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
Brewtils Changelog
==================

TBD
3.29.1
------
TBD

- Added support for display name to command decorator
- Updated Wait Timeout Exception expected HTTP code from 408 to 504
- Dropping Official Python 2.7 Support

3.29.0
------
Expand Down
7 changes: 0 additions & 7 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -118,12 +118,8 @@ docker-build-docs: docs
docker-build:
docker build -t $(DOCKER_NAME):python3-$(VERSION) --build-arg VERSION=$(VERSION) -f docker/python3/Dockerfile .
docker build -t $(DOCKER_NAME):python3-onbuild-$(VERSION) --build-arg VERSION=$(VERSION) -f docker/python3/onbuild/Dockerfile .
docker build -t $(DOCKER_NAME):python2-$(VERSION) --build-arg VERSION=$(VERSION) -f docker/python2/Dockerfile .
docker build -t $(DOCKER_NAME):python2-onbuild-$(VERSION) --build-arg VERSION=$(VERSION) -f docker/python2/onbuild/Dockerfile .
docker tag $(DOCKER_NAME):python3-$(VERSION) $(DOCKER_NAME):latest
docker tag $(DOCKER_NAME):python3-$(VERSION) $(DOCKER_NAME):python3
docker tag $(DOCKER_NAME):python2-$(VERSION) $(DOCKER_NAME):python2


# Documentation
docs-deps: deps ## install dependencies for documentation
Expand Down Expand Up @@ -161,11 +157,8 @@ publish-package: package ## upload a package
publish-docker: docker-build ## push the docker images
docker push $(DOCKER_NAME):python3-$(VERSION)
docker push $(DOCKER_NAME):python3-onbuild-$(VERSION)
docker push $(DOCKER_NAME):python2-$(VERSION)
docker push $(DOCKER_NAME):python2-onbuild-$(VERSION)
docker push $(DOCKER_NAME):latest
docker push $(DOCKER_NAME):python3
docker push $(DOCKER_NAME):python2

publish-docker-docs: docker-build-docs ## push the docker images
docker push $(DOCKER_NAME):docs-$(VERSION)
Expand Down
6 changes: 3 additions & 3 deletions brewtils/rest/easy_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -62,11 +62,11 @@ def handle_response_failure(response, default_exc=RestError, raise_404=True):
Raises:
NotFoundError: Status code 404 and raise_404 is True
WaitExceededError: Status code 408
ConflictError: Status code 409
TooLargeError: Status code 413
ValidationError: Any other 4xx status codes
RestConnectionError: Status code 503
WaitExceededError: Status code 504
default_exc: Any other status code
"""
try:
Expand All @@ -79,8 +79,6 @@ def handle_response_failure(response, default_exc=RestError, raise_404=True):
raise NotFoundError(message)
else:
return None
elif response.status_code == 408:
raise WaitExceededError(message)
elif response.status_code == 409:
raise ConflictError(message)
elif response.status_code == 413:
Expand All @@ -89,6 +87,8 @@ def handle_response_failure(response, default_exc=RestError, raise_404=True):
raise ValidationError(message)
elif response.status_code == 503:
raise RestConnectionError(message)
elif response.status_code == 504:
raise WaitExceededError(message)
else:
raise default_exc(message)

Expand Down
10 changes: 0 additions & 10 deletions docker/python2/Dockerfile

This file was deleted.

12 changes: 0 additions & 12 deletions docker/python2/onbuild/Dockerfile

This file was deleted.

2 changes: 1 addition & 1 deletion docker/python3/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM python:3.7-alpine as base
FROM python:3.11-alpine as base

ARG VERSION

Expand Down
2 changes: 0 additions & 2 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,6 @@ def find_version():
classifiers=[
"Intended Audience :: Developers",
"License :: OSI Approved :: MIT License",
"Programming Language :: Python :: 2",
"Programming Language :: Python :: 2.7",
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.6",
"Programming Language :: Python :: 3.7",
Expand Down
2 changes: 1 addition & 1 deletion test/rest/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def not_found():

@pytest.fixture
def wait_exceeded():
return Mock(ok=False, status_code=408, json=Mock(return_value="payload"))
return Mock(ok=False, status_code=504, json=Mock(return_value="payload"))


@pytest.fixture
Expand Down

0 comments on commit 86ac725

Please sign in to comment.