Fleet listing pages are visible without authentication (minmatarfleet…

…#443) * Fleet listing pages are visible without authentication * Replaced AuthButton for direct link
beautifulmim · Jun 5, 2024 · f8e3e44 · f8e3e44
1 parent 6e52572
commit f8e3e44
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 11 deletions.
diff --git a/frontend/app/src/pages/fleets/history.astro b/frontend/app/src/pages/fleets/history.astro
@@ -34,6 +34,8 @@ try {
 
 const FLEET_LIST_PARTIAL_URL = translatePath(`/partials/fleet_list_component?upcoming=${JSON.stringify(false)}`)
 
+import { get_auth_url } from '@helpers/env'
+
 import Viewport from '@layouts/Viewport.astro';
 
 import PageWide from '@components/page/PageWide.astro';
@@ -45,9 +47,7 @@ import FlexInline from '@components/compositions/FlexInline.astro';
 import FleetList from '@components/blocks/FleetList.astro';
 import Button from '@components/blocks/Button.astro';
 import ErrorRefetch from '@components/blocks/ErrorRefetch.astro';
-import ButtonAuth from '@components/blocks/ButtonAuth.astro';
 import ButtonStack from '@components/blocks/ButtonStack.astro';
-import ComponentBlock from '@components/blocks/ComponentBlock.astro';
 
 import AddIcon from '@components/icons/buttons/AddIcon.astro';
 
@@ -113,12 +113,12 @@ const page_title = t('fleets.history.page_title');
                     <FlexInline justification='space-between'>
                         <p>{t('authenticate_fleet_hint')}</p>
                         <ButtonStack>
-                            <ButtonAuth
+                            <Button
+                                href={get_auth_url()}
                                 size='sm'
-                                dialog_title={t('upcoming_fleets_dialog_title')}
                             >
                                 {t('authenticate')}
-                            </ButtonAuth>
+                            </Button>
                         </ButtonStack>
                     </FlexInline>
                 }

diff --git a/frontend/app/src/pages/fleets/upcoming.astro b/frontend/app/src/pages/fleets/upcoming.astro
@@ -37,6 +37,8 @@ try {
 
 const FLEET_LIST_PARTIAL_URL = translatePath(`/partials/fleet_list_component?upcoming=${JSON.stringify(true)}`)
 
+import { get_auth_url } from '@helpers/env'
+
 import Viewport from '@layouts/Viewport.astro';
 
 import PageWide from '@components/page/PageWide.astro';
@@ -48,13 +50,10 @@ import FlexInline from '@components/compositions/FlexInline.astro';
 import FleetList from '@components/blocks/FleetList.astro';
 import Button from '@components/blocks/Button.astro';
 import ErrorRefetch from '@components/blocks/ErrorRefetch.astro';
-import ButtonAuth from '@components/blocks/ButtonAuth.astro';
 import ButtonStack from '@components/blocks/ButtonStack.astro';
-import ComponentBlock from '@components/blocks/ComponentBlock.astro';
 
 import AddIcon from '@components/icons/buttons/AddIcon.astro';
 
-
 const page_title = t('fleets.upcoming.page_title');
 ---
 
@@ -121,12 +120,12 @@ const page_title = t('fleets.upcoming.page_title');
                     <FlexInline justification='space-between'>
                         <p>{t('authenticate_fleet_hint')}</p>
                         <ButtonStack>
-                            <ButtonAuth
+                            <Button
+                                href={get_auth_url()}
                                 size='sm'
-                                dialog_title={t('upcoming_fleets_dialog_title')}
                             >
                                 {t('authenticate')}
-                            </ButtonAuth>
+                            </Button>
                         </ButtonStack>
                     </FlexInline>
                 }