Fixing get_moons (?) (minmatarfleet#792)

beautifulmim · Oct 8, 2024 · 4435b3f · 4435b3f
1 parent 105a683
commit 4435b3f
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/backend/moons/router.py b/backend/moons/router.py
@@ -1,4 +1,4 @@
-from typing import List
+from typing import List, Optional
 
 from ninja import Router
 from pydantic import BaseModel
@@ -30,7 +30,7 @@ class MoonViewResponse(BaseModel):
     system: str
     planet: str
     moon: int
-    detail: MoonDetailResponse
+    detail: Optional[MoonDetailResponse]
 
 
 class MoonResponse(BaseModel):
@@ -153,12 +153,12 @@ def get_moons(request, system: str = None):
             system=moon.system,
             planet=moon.planet,
             moon=moon.moon,
-            reported_by=reported_by_user,
+            reported_by="-",
         )
 
         if view_distribution:
             detail = MoonDetailResponse(
-                reported_by=moon.reported_by,
+                reported_by=reported_by_user,
                 monthly_revenue=moon.monthly_revenue,
             )
             moon_response.detail = detail