WIP: Hotfix/fix exemplars for counters #459
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pc, sql, redis, etc; put success label as err == nil for all of the clients
run goimports added support of Prometheus exemplars to components http middleware and gRPC observability
…t' into feat/prometheus-exemplars-support
…t' into feat/prometheus-exemplars-support
EvgeniaMartynova-thebeat
changed the title
EvgeniaMartynova-thebeat
deleted the
hotfix/fix-exemplars-for-counters
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
In this PR we introduced support for Prometheus Exemplars for all counter and histogram metrics in clients and components. However according to OpenMetrics specification counter metric names should have suffix
_totaland histogram metrics names should have suffix_bucketin order to have the metrics augmented with exemplars. We found out that not following the requirement will bring a Service Monitor down.In the logs of Service Monitor the following error would appear:
This error is coming from [this func] (https://github.com/prometheus/prometheus/blob/4c56a193c518ae6f56008b0a4c850a9c3f1477c6/model/textparse/openmetricsparse.go#L362)
Where there is a comment:
and here is the definition of function
Short description of the changes
Enabling exemplars only for counter metrics which have a name ending with a suffix
_total._bucketsuffix for Histograms is added by Prometheus itself, so we don’t need to worry about this. Please refer to the source code