Fix config modify index validation log levels (#54)

beatlabs · Jul 29, 2020 · 059c67c · 059c67c
1 parent cf6fa53
commit 059c67c
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 21 deletions.
diff --git a/config/config.go b/config/config.go
@@ -83,8 +83,13 @@ func (f *Field) String() string {
 
 // Set the value of the field.
 func (f *Field) Set(value string, version uint64) error {
-	if version != 0 && version <= f.version {
-		log.Warnf("version %d is older or same as the field's %s", version, f.name)
+	if version != 0 && version < f.version {
+		log.Errorf("version %d is older than the field's %q (version %d)", version, f.name, f.version)
+		return nil
+	}
+
+	if version != 0 && version == f.version {
+		log.Debugf("version %d is the same as field's %q", version, f.name)
 		return nil
 	}
 
@@ -93,7 +98,7 @@ func (f *Field) Set(value string, version uint64) error {
 	}
 
 	f.version = version
-	log.Infof("field %s updated with value %v, version: %d", f.name, f, version)
+	log.Infof("field %q updated with value %q, version: %d", f.name, f, version)
 	return nil
 }
 

diff --git a/harvester_integration_test.go b/harvester_integration_test.go
@@ -21,24 +21,24 @@ import (
 var (
 	csl       *api.KV
 	secretLog = []string{
-		"INFO: field Name updated with value ***, version: ",
-		"INFO: seed value *** applied on field Name",
-		"INFO: field Name updated with value ***, version: ",
-		"INFO: consul value *** applied on field Name",
-		"INFO: field Age updated with value 18, version: ",
-		"INFO: seed value 18 applied on field Age",
-		"INFO: field Age updated with value 99, version: ",
-		"INFO: consul value 99 applied on field Age",
-		"INFO: field Balance updated with value 99.900000, version: ",
-		"INFO: seed value 99.900000 applied on field Balance",
-		"INFO: field Balance updated with value 111.100000, version: ",
-		"INFO: consul value 111.100000 applied on field Balance",
-		"INFO: field HasJob updated with value true, version: ",
-		"INFO: seed value true applied on field HasJob",
-		"INFO: field HasJob updated with value false, version: ",
-		"INFO: consul value false applied on field HasJob",
-		"INFO: plan for key harvester1/name created",
-		"INFO: plan for keyprefix harvester created",
+		`INFO: field "Name" updated with value "***", version: `,
+		`INFO: seed value *** applied on field Name`,
+		`INFO: field "Name" updated with value "***", version: `,
+		`INFO: consul value *** applied on field Name`,
+		`INFO: field "Age" updated with value "18", version: `,
+		`INFO: seed value 18 applied on field Age`,
+		`INFO: field "Age" updated with value "99", version: `,
+		`INFO: consul value 99 applied on field Age`,
+		`INFO: field "Balance" updated with value "99.900000", version: `,
+		`INFO: seed value 99.900000 applied on field Balance`,
+		`INFO: field "Balance" updated with value "111.100000", version: `,
+		`INFO: consul value 111.100000 applied on field Balance`,
+		`INFO: field "HasJob" updated with value "true", version: `,
+		`INFO: seed value true applied on field HasJob`,
+		`INFO: field "HasJob" updated with value "false", version: `,
+		`INFO: consul value false applied on field HasJob`,
+		`INFO: plan for key harvester1/name created`,
+		`INFO: plan for keyprefix harvester created`,
 	}
 )