Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[in-review] Fix search by company name and search by industry name #693

Merged
merged 2 commits into from
Dec 22, 2023
Merged

[in-review] Fix search by company name and search by industry name #693

merged 2 commits into from
Dec 22, 2023

Conversation

imahmedismail
Copy link
Contributor

  • Fix search by name
  • Fix search by industry

@imahmedismail imahmedismail requested a review from a team as a code owner November 7, 2023 18:40
@imahmedismail imahmedismail mentioned this pull request Nov 7, 2023
Closed
@imahmedismail imahmedismail force-pushed the imahmedismail/fix-search-by-company-name-and-search-by-industry branch from 55aebc1 to b357582 Compare November 7, 2023 18:42
@imahmedismail
Copy link
Contributor Author

imahmedismail commented Nov 21, 2023 •
edited
Loading

Please review this ?
cc: @doomspork @samuelpordeus

@doomspork
Copy link
Member

@imahmedismail I'm sorry 😓 I don't know how I missed the notification for this. Could we consider adding some test coverage?

@imahmedismail
Copy link
Contributor Author

Sure @doomspork

@imahmedismail imahmedismail force-pushed the imahmedismail/fix-search-by-company-name-and-search-by-industry branch from b357582 to 69626b3 Compare December 21, 2023 16:10
@imahmedismail
Copy link
Contributor Author

You can review it now.
cc: @doomspork

doomspork
doomspork approved these changes Dec 22, 2023
View reviewed changes
Copy link
Member

@doomspork doomspork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wonderful, thanks for the added test coverage @imahmedismail!

@doomspork doomspork added this pull request to the merge queue Dec 22, 2023
Merged via the queue into beam-community:main with commit 93e0379 Dec 22, 2023
5 checks passed
@imahmedismail
Copy link
Contributor Author

This is wonderful, thanks for the added test coverage @imahmedismail!

My pleasure! @doomspork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doomspork doomspork doomspork approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imahmedismail @doomspork