Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/straglr #318

Merged
merged 7 commits into from
Mar 10, 2022
Merged

Feature/straglr #318

merged 7 commits into from
Mar 10, 2022

Conversation

creisle
Copy link
Member

@creisle creisle commented Mar 4, 2022 •
edited
Loading

@creisle creisle added the SV caller Tickets related to support for inputs from different SV callers label Mar 4, 2022
@creisle creisle added this to the v3.1.0 milestone Mar 4, 2022
@creisle creisle self-assigned this Mar 4, 2022
@creisle creisle linked an issue Mar 4, 2022 that may be closed by this pull request
Straglr conversion support to json for MAVIS annotation #317
Open
@codecov
Copy link

codecov bot commented Mar 4, 2022 •
edited
Loading

Codecov Report

Merging #318 (59e0167) into develop_v3 (9f288e6) will increase coverage by 0.01%.
The diff coverage is 87.50%.

Impacted file tree graph

@@              Coverage Diff               @@
##           develop_v3     #318      +/-   ##
==============================================
+ Coverage       86.44%   86.45%   +0.01%     
==============================================
  Files              54       55       +1     
  Lines            9281     9289       +8     
  Branches         2397     2398       +1     
==============================================
+ Hits             8023     8031       +8     
  Misses            778      778              
  Partials          480      480
Flag Coverage Δ
unittests 86.45% <87.50%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/mavis/convert/__init__.py 87.50% <66.66%> (+0.28%) ⬆️
src/mavis/convert/constants.py 100.00% <100.00%> (ø)
src/mavis/convert/straglr.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d689e2d...59e0167. Read the comment docs.

zhemingfan
zhemingfan previously approved these changes Mar 8, 2022
View reviewed changes
@creisle creisle merged commit 9aa0415 into develop_v3 Mar 10, 2022
@creisle creisle deleted the feature/straglr branch March 10, 2022 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattdoug604 mattdoug604 mattdoug604 approved these changes

@zhemingfan zhemingfan Awaiting requested review from zhemingfan

Assignees

@creisle creisle

Labels
SV caller Tickets related to support for inputs from different SV callers
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.

Straglr conversion support to json for MAVIS annotation
3 participants
@creisle @mattdoug604 @zhemingfan