-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable issue cred v20 protocol for BC Reg issuer #356
Conversation
Signed-off-by: Ian Costanzo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻
@WadeBarnes I'll let you merge it when it is best to get the changes deployed and assessed in dev
Signed-off-by: Ian Costanzo <[email protected]>
@ianco unsurprisingly this PR has become a bit stale and there are conglicts that need resolving now. Mind taking a quick look? |
Are there any dependencies on the OrgBook side required for this to work? Also we have some comments here (bcgov/von-bc-registries-agent-configurations#79 (comment)) about the order we want to upgrade the ACA-Py versions. Are theses changes independent of those updates? |
I think if we use V10 things should work as they are now. If we switch to V20 we would have to update the OrgBook side as well since the webhook payload would be slightly different. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻
Add support for v20 credential exchange. Specify the protocol to use using the env var
ISSUE_CRED_VERSION
- values areV10
andV20
(default isV10
if not specified).This can be set for the container, or specifically for the cred submitter job as follows: