Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable issue cred v20 protocol for BC Reg issuer #356

Merged
merged 4 commits into from
Sep 16, 2024

Conversation

ianco
Copy link
Contributor

@ianco ianco commented May 24, 2024

Add support for v20 credential exchange. Specify the protocol to use using the env var ISSUE_CRED_VERSION - values are V10 and V20 (default is V10 if not specified).

This can be set for the container, or specifically for the cred submitter job as follows:

ISSUE_CRED_VERSION=V20 ./run-step.sh bcreg/submit-creds.py
ISSUE_CRED_VERSION=V20 ./run-step.sh bcreg/submit-creds_lear.py

@ianco ianco marked this pull request as draft May 24, 2024 17:23
@ianco ianco changed the title Emable issue cred v20 protocol for BC Reg issuer Enable issue cred v20 protocol for BC Reg issuer May 24, 2024
@ianco ianco marked this pull request as ready for review May 27, 2024 15:18
@ianco ianco requested review from esune, WadeBarnes and amanji May 27, 2024 15:18
@WadeBarnes WadeBarnes self-assigned this May 27, 2024
esune
esune previously approved these changes Jun 6, 2024
Copy link
Member

@esune esune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@WadeBarnes I'll let you merge it when it is best to get the changes deployed and assessed in dev

@esune
Copy link
Member

esune commented Sep 10, 2024

@ianco unsurprisingly this PR has become a bit stale and there are conglicts that need resolving now. Mind taking a quick look?

@WadeBarnes
Copy link
Member

Are there any dependencies on the OrgBook side required for this to work? Also we have some comments here (bcgov/von-bc-registries-agent-configurations#79 (comment)) about the order we want to upgrade the ACA-Py versions. Are theses changes independent of those updates?

@esune
Copy link
Member

esune commented Sep 11, 2024

Are there any dependencies on the OrgBook side required for this to work? Also we have some comments here (bcgov/von-bc-registries-agent-configurations#79 (comment)) about the order we want to upgrade the ACA-Py versions. Are theses changes independent of those updates?

I think if we use V10 things should work as they are now. If we switch to V20 we would have to update the OrgBook side as well since the webhook payload would be slightly different.

Copy link
Member

@esune esune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@WadeBarnes WadeBarnes merged commit f219a7e into bcgov:main Sep 16, 2024
@WadeBarnes
Copy link
Member

Changes have been deployed to dev and test.
cc @ianco @esune

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants