New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

21519 - Rework partner disbursement job so it works with multiple link and unlinking #1637

Merged

seeker25 merged 62 commits into bcgov:main from seeker25:21519

Oct 3, 2024

Collaborator

seeker25 commented Jul 24, 2024 •

edited

Loading

Issue #:
bcgov/entity#21519

Description of changes:
Requires some changes on the pay-queue as well to handle the new identifiers etc
Handle invoice refunds

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).


          Fix filename off by 1 ms bug

922bdeb

seeker25 requested review from Jxio, ochiu, rodrigo-barraza and avni-work as code owners

July 24, 2024 00:18

seeker25 changed the title ~~21519~~ 21519 - Rework partner disbursement job so it works with multiple link and unlinking

seeker25 marked this pull request as draft

July 24, 2024 00:19

seeker25 commented

View reviewed changes

jobs/payment-jobs/tasks/ap_task.py Outdated Show resolved Hide resolved

seeker25 commented

View reviewed changes

pay-api/src/pay_api/models/partner_disbursements.py Show resolved Hide resolved

seeker25 commented

View reviewed changes

pay-api/src/pay_api/services/eft_short_names.py Outdated Show resolved Hide resolved

seeker25 commented

View reviewed changes

jobs/payment-jobs/tasks/ejv_partner_distribution_task.py Show resolved Hide resolved

seeker25 commented

View reviewed changes

jobs/payment-jobs/tasks/ejv_partner_distribution_task.py Outdated Show resolved Hide resolved

seeker25 commented

View reviewed changes

jobs/payment-jobs/tasks/ejv_partner_distribution_task.py Outdated Show resolved Hide resolved

seeker25 commented

View reviewed changes

jobs/payment-jobs/tasks/ejv_partner_distribution_task.py Outdated Show resolved Hide resolved

seeker25 commented

View reviewed changes

pay-api/src/pay_api/services/eft_service.py Show resolved Hide resolved

seeker25 commented

View reviewed changes

pay-api/src/pay_api/services/eft_service.py Outdated Show resolved Hide resolved

seeker25 commented

View reviewed changes

jobs/payment-jobs/tasks/ejv_partner_distribution_task.py Outdated Show resolved Hide resolved

seeker25 commented

View reviewed changes

jobs/payment-jobs/tasks/common/dataclasses.py Outdated Show resolved Hide resolved

Jxio reviewed

View reviewed changes

pay-api/migrations/versions/2024_07_18_aae01971bd53_.py Outdated Show resolved Hide resolved

seeker25 mentioned this pull request

22588 - Revert partner disbursements, fix migration processes, update versions, prod PREP #1651

Merged

seeker25 closed this

seeker25 reopened this


          21519 - Work on partner disbursements

c3fa976

seeker25 force-pushed the 21519 branch from 1252731 to c3fa976 Compare

September 6, 2024 21:54

seeker25 added 6 commits

September 6, 2024 14:55


          Fix filename off by 1 ms bug

caaebc8


          21519 - Work on partner disbursements

151ef1e


          Merge branch '21519' of https://github.com/seeker25/sbc-pay into 21519

b59a21f

# Conflicts:
#	jobs/payment-jobs/tasks/ejv_partner_distribution_task.py
#	pay-api/pre-hook-update-db.sh
#	pay-api/tests/unit/api/test_eft_short_name_history.py


          Fix missing import again

769b969


          fix pylock

2b94dad


          lint issues

cb23f39

Jxio approved these changes

View reviewed changes

Collaborator

Jxio left a comment

Looks good to me!

seeker25 added 5 commits

October 1, 2024 10:08


          Merge branch 'main' of https://github.com/bcgov/sbc-pay into 21519

f3f5b1b


          update poetry lock

207df2e


          Clean up migrations

8987b82


          shuffle migrations up

90b6041


          Fix dep

7b71327

Collaborator Author

seeker25 commented Oct 1, 2024 •

edited

Loading

Completed:

Minor check EFT disbursement
Migration to generate partner disbursement rows for existing EFT invoices (will reuse this later hopefully)
Side by side testing with old code testing invoices with various states (Tested with a huge range of data)
Triple check we aren't including service fees
Block for partial refunds

seeker25 added 2 commits

October 1, 2024 14:17


          Fixes when doing side by side testing

2d5e7ca


          Fix line numbers

seeker25 commented

View reviewed changes

pay-api/src/pay_api/services/eft_refund.py Outdated Show resolved Hide resolved

seeker25 commented

View reviewed changes

pay-api/src/pay_api/services/eft_service.py Outdated Show resolved Hide resolved

seeker25 commented

View reviewed changes

pay-api/src/pay_api/services/eft_service.py Outdated Show resolved Hide resolved

seeker25 added 10 commits

October 1, 2024 16:42


          exclude service fees from partner disbursements model

c29620b


          small fix for service fees

082c8d8


          minor tweaks

f0f0306


          Merge branch 'main' of https://github.com/bcgov/sbc-pay into 21519

bd5779f


          fix migration

33545c9


          resync

e540d73


          Tweak partial refund

175c1d5


          remove comment

21bef6f


          migration to populate partner disbursements

27ae40c


          lint fixes

543e74b

Collaborator Author

seeker25 commented Oct 2, 2024

Just trying EFT + EFT reversals locally now, after that I'll merge


          Small tweak

468f2b0

seeker25 removed the DoNotMerge label

seeker25 added 4 commits

October 2, 2024 09:38


          update reference

7221d7e


          rename enum

e756f8e


          Change reversal code a tad

64c1486


          Merge branch 'main' of https://github.com/bcgov/sbc-pay into 21519

d96c7c8

seeker25 merged commit 1102953 into bcgov:main

16 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet