15687 - Pay remove restx

[ochiu]

Issue #:
bcgov/entity#15687

Description of changes:

• remove restx from pay-api

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

[codecov]

Codecov Report

Merging #1234 (7ede26c) into main (28ff797) will decrease coverage by 0.86%.
Report is 86 commits behind head on main.
The diff coverage is 91.69%.

@@            Coverage Diff             @@
##             main    #1234      +/-   ##
==========================================
- Coverage   91.54%   90.69%   -0.86%     
==========================================
  Files         153      189      +36     
  Lines        9842    11414    +1572     
==========================================
+ Hits         9010    10352    +1342     
- Misses        832     1062     +230     

Flag	Coverage Δ
bcolapi	∅ <ø> (?)
eventlistenerqueue	81.81% <ø> (-0.48%)	⬇️
ftppoller	0.00% <ø> (?)
payadmin	∅ <ø> (?)
payapi	93.73% <91.76%> (-0.17%)	⬇️
paymentjobs	80.22% <90.40%> (+1.26%)	⬆️
paymentreconciliationsqueue	91.44% <95.38%> (?)
reportapi	91.09% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
jobs/payment-jobs/tasks/ejv_payment_task.py	96.46% <ø> (ø)
jobs/payment-jobs/tasks/routing_slip_task.py	89.09% <0.00%> (-0.43%)	⬇️
pay-api/src/pay_api/services/fee_schedule.py	99.53% <ø> (-0.01%)	⬇️
jobs/payment-jobs/tasks/cfs_create_invoice_task.py	72.44% <50.00%> (-0.24%)	⬇️
...i/resources/v1/account_statements_notifications.py	55.81% <55.81%> (ø)
pay-api/src/pay_api/services/bcol_service.py	86.13% <61.53%> (-2.10%)	⬇️
...ay-api/src/pay_api/services/gcp_queue_publisher.py	64.70% <64.70%> (ø)
...ons/src/reconciliations/payment_reconciliations.py	91.16% <76.92%> (ø)
pay-api/src/pay_api/resources/v1/bank_accounts.py	77.41% <77.41%> (ø)
jobs/payment-jobs/tasks/statement_task.py	80.43% <79.66%> (+9.46%)	⬆️
... and 82 more

... and 37 files with indirect coverage changes

📢 Have feedback on the report? Share it here.

[Jxio]

can ops.py move to ../v1/ ?

[ochiu]

The ops endpoint is part of the /ops route and not under /api/v1, so I kept it out of the v1 folder as it is not specific to a version.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[seeker25]

Please move git mv to preserve the history of the files.

[seeker25]

Please use git mv to preserve the history of the files. This is more important in PAY than AUTH.

[seeker25]

After reviewing with Ody, git mv wasn't the issue. It's done in the commits

Incorrect

[seeker25]

Another thing to note we discovered: when moving these files - better not to Squash and merge as is