24281 - Skip completed payment on _verify_created_direct_pay_invoices (…

…#1816)
bcgov · Nov 7, 2024 · 92d8555 · 92d8555
1 parent 98a1f10
commit 92d8555
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/jobs/payment-jobs/tasks/stale_payment_task.py b/jobs/payment-jobs/tasks/stale_payment_task.py
@@ -118,6 +118,10 @@ def _verify_created_direct_pay_invoices(cls):
                 if paybc_invoice.paymentstatus in STATUS_PAID:
                     current_app.logger.debug("_update_active_transactions")
                     transaction = TransactionService.find_active_by_invoice_id(invoice.id)
+                    payment = PaymentModel.find_by_id(transaction.payment_id)
+
+                    if payment.payment_status_code == PaymentStatus.COMPLETED.value:
+                        continue
                     if transaction:
                         # check existing payment status in PayBC and save receipt
                         TransactionService.update_transaction(transaction.id, pay_response_url=None)