Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 1580 list favorite activities for consep #1771

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

xiaopeng0202
Copy link
Collaborator

@xiaopeng0202 xiaopeng0202 commented Dec 9, 2024

Description

Closes #1580

Changelog

New

  • Add a new page for consep favorite activities. The behavior will look like spar favorite activities.

How was this tested?

  • 🧠 Not needed
  • 👀 Eyeball
  • 🤖 Added tests

What gif/image best describes this PR or how it makes you feel?


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@xiaopeng0202 xiaopeng0202 changed the title Feat/1580 list favorite activities for consep Feat: 1580 list favorite activities for consep Dec 9, 2024
@xiaopeng0202 xiaopeng0202 changed the title Feat: 1580 list favorite activities for consep feat: 1580 list favorite activities for consep Dec 9, 2024
Copy link
Collaborator

@mgaseta mgaseta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!
Added a few markups on the code.

Not sure if it's in the scope of this task, but there is no menu entry for this consep page... I had to access the new page via the URL.

@xiaopeng0202
Copy link
Collaborator Author

Nice job! Added a few markups on the code.

Not sure if it's in the scope of this task, but there is no menu entry for this consep page... I had to access the new page via the URL.

We will miss the menu entry for now, only accessed by url

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CONSEP landing dashboard cards
2 participants