Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

24481 - Fix versioned business issue for loading placeholder state filing #3107

Merged
merged 2 commits into from
Dec 3, 2024
Merged

24481 - Fix versioned business issue for loading placeholder state filing #3107

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b71ff00
24481 - versioned business issue for loading placeholder state filing
chenhongjing Dec 3, 2024
43ef8dc
add comment for tombstone business revision issue
chenhongjing Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions legal-api/src/legal_api/services/business_details_version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -594,6 +594,10 @@ def resolution_json(resolution_revision) -> dict:
@staticmethod
def business_revision_json(business_revision, business_json):
"""Return the business revision as a json object."""
# business_revision for tombstone business will be None
# check and skip to return original business_json
if not business_revision:
return business_json
argush3 marked this conversation as resolved.
Show resolved Hide resolved
business_json['hasRestrictions'] = business_revision.restriction_ind
business_json['dissolutionDate'] = LegislationDatetime.format_as_legislation_date(
business_revision.dissolution_date) if business_revision.dissolution_date else None
Expand Down