Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

22954 - Verify future-effective-filings job to use new db versioning #3104

Conversation

AimeeGao
Copy link
Collaborator

Issue #: /bcgov/entity#22954

Description of changes:

  1. Investigated the job's functionality:

    • Job only handles API calls from legal-api and queue messages
    • No direct DB operations
    • No legal-api package usage
  2. Conclusions:

    • No changes needed in db versioning setup
    • Remove the future-effective-filings flag in legal-api's flags.json
  3. Verification steps:

    • Tested legal-api with feature flags ON & OFF
    • Verified future-effective-filings job functionality
    • Confirmed queue message processing works correctly in local environment
    • All unit tests passed successfully

ScreenShots:

  • Legal-API OFF

    • Job works successfully in local environment
      image
  • Legal-API ON

  1. Created a Future Effective Filing (Change of Address) - Filing ID: 151265
    image
  2. Verified filing exists in local DB
    image
  3. Updated filing status to PAID for testing
    image
  4. Then run the job locally again and confirm filing successfully queued after job execution
    image
  5. Verified passed all unit test
    image

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

eason-pan-bc

This comment was marked as resolved.

@AimeeGao

This comment was marked as resolved.

Copy link

sonarcloud bot commented Dec 3, 2024

@AimeeGao AimeeGao merged commit 2dcbab4 into bcgov:feature-db-versioning Dec 3, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants