20989 - Exclude USA conditionally #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@severinbeauvais thanks for spotting this bug. |
JazzarKarim
reviewed
May 7, 2024
| } | ||
|
|
||
| return excludedValues | ||
| } |
There was a problem hiding this comment.
Whoa, this gets called for every item in the Intl list. And it does a lot of work.
Try something simpler.
There was a problem hiding this comment.
I think you only need a simple conditional here that returns False if filter should exclude it, else True.
severinbeauvais
approved these changes
May 7, 2024
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#20989
Description of changes:
Changed header text to 'USA' for Testing only. Does not have United Sates in the International jurisdiction list anymore:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).