Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port the g.Tec driver to PyUSB 1.0 #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tdy
Copy link

@tdy tdy commented Aug 9, 2016

Hello, I've patched gtec.py to use the pyusb-1.0.0 API.

@tdy tdy force-pushed the port-gtec-pyusb1.0 branch 3 times, most recently from 832e20d to 7a68066 Compare August 9, 2016 02:01
@tdy tdy force-pushed the port-gtec-pyusb1.0 branch from 7a68066 to f12c3aa Compare August 9, 2016 02:06
@okbalefthanded
Copy link

@tdy I'm having an issue with the gusbamp class, when running the amp.getdata() an exception of the type "Not ImplementedError" is raised, the method concerned is get_sample_frequency used by the Ampdecorator for getting marker, which is not implemented in the GUSBAmp, I also noticed that the configure method is also missing, by default at the init method the sampling frequency is set to 128 HZ.

If you're running into the same issue inform me, otherwise is everything is working fine please inform also.

@tdy
Copy link
Author

tdy commented Aug 9, 2016

@okbalefthanded I noticed the issue as well. For me, the same issue exists with the master branch. gtec.py can run as a standalone script, but from what I can tell, it was never fully implemented as a module.

In this branch, I've only translated the existing legacy code line by line into the 1.0.0 (stable) API. This involved updating the amp's USB initialization code and updating the controlMsg() and readBulk() signatures.

@okbalefthanded
Copy link

@tdy Thanks for your reply, I'll update my local code with your patch and try to complete the implementation if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants