Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: move string-only JSON examples to the spec. YAML #95

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

philipnbbc
Copy link
Contributor

Details

Workaround redocly rendering issue which omits the quotes, which makes it an invalid JSON string.

Pivotal Story (if relevant)

Story URL: https://www.pivotaltracker.com/story/show/188197505

Related PRs

Where appropriate. Indicate order to be merged.

Submitter PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • API version has been incremented if necessary
  • ADR status has been updated, and ADR implementation has been recorded
  • Documentation updated (README, etc.)
  • PR added to Pivotal story (if relevant)
  • Follow-up stories added to Pivotal

Reviewer PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • Design makes sense, and fits with our current code base
  • Code is easy to follow
  • PR size is sensible
  • Commit history is sensible and tidy

Info on PRs

The checks above are guidelines. They don't all have to be ticked, but they should all have been considered.

Workaround redocly rendering issue which omits the quotes, which makes
it an invalid JSON string.
@philipnbbc philipnbbc requested a review from a team as a code owner November 18, 2024 16:54
Copy link
Member

@samdbmg samdbmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂 Should've read this one before writing my comment in #91 (comment)

LGTM

@philipnbbc philipnbbc merged commit f326e28 into main Nov 21, 2024
5 checks passed
@philipnbbc philipnbbc deleted the philipn-fix-tag-update-rendering branch November 21, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants