-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ADR for a query option to filter get_urls
#88
base: main
Are you sure you want to change the base?
Conversation
fc6acb8
to
84cbe85
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A suggested change and a typo.
Once changed, LGTM.
Co-authored-by: Andrew Gibb <[email protected]>
Co-authored-by: Andrew Gibb <[email protected]>
ace6ebc
to
d5ebe4a
Compare
This PR will be left open for now as further discussion is needed to understand whether it fits the requirements or not. |
Follow the Workshop where this was discussed, we should also update the App Note describing the |
Details
This PR adds an ADR that proposes a
accept_get_urls
query option to filter flow segmentget_urls
. This allows clients to indicate that pre-signed URLs are not required, potentially significantly reducing the request time when requesting a large number of flow segments.Pivotal Story (if relevant)
Story URL: https://www.pivotaltracker.com/story/show/187930100
Related PRs
Where appropriate. Indicate order to be merged.
Submitter PR Checks
(tick as appropriate)
Reviewer PR Checks
(tick as appropriate)
Info on PRs
The checks above are guidelines. They don't all have to be ticked, but they should all have been considered.