Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent naming and description of creating or updating metadata #77

Merged
merged 4 commits into from
Jul 24, 2024

Conversation

philipnbbc
Copy link
Contributor

Details

This PR makes some of the summary and description associated with Flow and Source metadata PUT operations consistent.

Pivotal Story (if relevant)

Story URL: https://www.pivotaltracker.com/story/show/187992106

Related PRs

Where appropriate. Indicate order to be merged.

Submitter PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • API version has been incremented if necessary
  • ADR status has been updated, and ADR implementation has been recorded
  • Documentation updated (README, etc.)
  • PR added to Pivotal story (if relevant)
  • Follow-up stories added to Pivotal

Reviewer PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • Design makes sense, and fits with our current code base
  • Code is easy to follow
  • PR size is sensible
  • Commit history is sensible and tidy

Info on PRs

The checks above are guidelines. They don't all have to be ticked, but they should all have been considered.

Given that there is a DELETE method. This aligns it with the wording
used for tags.
The read_only property is always present, i.e. can't be DELETEd
@philipnbbc philipnbbc requested a review from a team as a code owner July 24, 2024 11:34
Copy link
Member

@samdbmg samdbmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

api/TimeAddressableMediaStore.yaml Outdated Show resolved Hide resolved
@philipnbbc philipnbbc merged commit a83fc22 into main Jul 24, 2024
5 checks passed
@philipnbbc philipnbbc deleted the philipn-consistent-create-update-wording branch July 24, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants