api: allow flow segment paging using opaque key #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow the next page link to include a "page" query parameter that allows the next page to be retrieved. If the TAMS implementations uses "page" then it will likely leave the "timerange" query parameter unchanged. Marking this change as a feature rather than a breaking change because clients should be treating the query parameters of a page link as opaque. sem-ver: feature
j616
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Allow the next page link to include a "page" query parameter that allows the next page to be retrieved. If the TAMS implementations uses the "page" parameter then it will likely leave the "timerange" query parameter unchanged.
Marking this change as a feature rather than a breaking change because clients should be treating the query parameters of a page link as opaque (given that the "page" parameter is opaque and any potential relationship with the other parameters is unknown).
Pivotal Story (if relevant)
Story URL: https://www.pivotaltracker.com/story/show/187930075
Related PRs
Where appropriate. Indicate order to be merged.
Submitter PR Checks
(tick as appropriate)
Reviewer PR Checks
(tick as appropriate)
Info on PRs
The checks above are guidelines. They don't all have to be ticked, but they should all have been considered.