Added Rust 1.82.0 #2944
Merged
Added Rust 1.82.0 #2944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UebelAndre
force-pushed
the
rustup
branch
5 times, most recently
from
3d83e3d
to
ca63f20
Compare
UebelAndre
force-pushed
the
rustup
branch
4 times, most recently
from
14d5269
to
d4d515d
Compare
UebelAndre
commented
Oct 18, 2024
| @@ -6,6 +6,11 @@ rust_library( | |||
| srcs = glob(["src/**/*.rs"]), | |||
| aliases = aliases(), | |||
| proc_macro_deps = all_crate_deps(proc_macro = True), | |||
| # TODO: https://github.com/bazelbuild/rules_rust/issues/2947 | |||
illicitonion
approved these changes
Oct 20, 2024
UebelAndre
force-pushed
the
rustup
branch
2 times, most recently
from
4bf4d17
to
e0a294f
Compare
|
When using rules_rust 0.54, we see this error: This seems due to this change. Does this mean rustc < 1.74.0 is no longer supported? |
|
No - our CI tests that rustc 1.72.1 is supported: rules_rust/.bazelci/presubmit.yml Line 7 in 60515a1 |
|
Well, we are using I see there is a static binary build with musl which would work, but this is never used automatically, AFAICS. I can work around with: load("@rules_rust//crate_universe/private:urls.bzl", "CARGO_BAZEL_URLS", "CARGO_BAZEL_SHA256S")
crates_repository(
...
generator_urls = CARGO_BAZEL_URLS | {
"x86_64-unknown-linux-gnu": CARGO_BAZEL_URLS["x86_64-unknown-linux-musl"],
},
generator_sha256s = CARGO_BAZEL_SHA256S | {
"x86_64-unknown-linux-gnu": CARGO_BAZEL_SHA256S["x86_64-unknown-linux-musl"],
},
)but that leads to a different error when repinning: Seems like the cargo-bazel binary assumes a target that is not supported by rustc 1.73.0 ? λ /home/claudio/.cache/bazel/_bazel_claudio/2fef88099e02b50d30aa33e59040bc18/external/nix_rust/bin/rustc --print target-list | grep wasm
wasm32-unknown-emscripten
wasm32-unknown-unknown
wasm32-wasi
wasm32-wasi-preview1-threads
wasm64-unknown-unknown.... OK, I can set the How do you think about using the musl binary by default (and drop the gnu binary as it has no added value and is even slightly larger)? |
1 task
|
I'd be happy to switch to the musl binary - want to send a PR? :) |
Sure, I'll look into that. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://blog.rust-lang.org/2024/10/17/Rust-1.82.0.html