refactor: fold per-target python version into base rules #2541
+90
−270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickeylev
force-pushed
the
refactor.consolidate.pyversion.transition
branch
3 times, most recently
from
41e1574 to
73df96d
Compare
rickeylev
force-pushed
the
refactor.consolidate.pyversion.transition
branch
from
73df96d to
535be2f
Compare
aignas
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, specifying the Python version for a target requires using the version-aware
rules in
transition.bzl(or the generated equivalents bound to a specific Pythonversion). With the rules rewritten in Bazel, that functionality can be moved into
the base rules themselves. Moving the logic into the base rules simplifies the
implementation and avoids having to re-implement subtle behaviors in the wrappers
to correctly emulate the wrapped target.
For backwards compatibility, the symbols in
transition.bzlare left as aliasesto the underlying rules.