Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gazelle): Don't ignore setup.py files when running Gazelle #2536

Merged
merged 4 commits into from
Dec 31, 2024

Conversation

dougthor42
Copy link
Collaborator

Don't ignore setup.py files when running Gazelle.

Fixes #2108.

I believe that setup.py was originally ignored because it, when found that the repo root, is part of setuptools config and may have caused problems with Gazelle.

I've been running our Google Quantum code with this patch for a long while now and not seen any issues. I figured it was time to upstream it.

@dougthor42 dougthor42 marked this pull request as ready for review December 26, 2024 22:24
Copy link
Collaborator

@aignas aignas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@aignas aignas added this pull request to the merge queue Dec 31, 2024
Merged via the queue into bazelbuild:main with commit 9035db2 Dec 31, 2024
4 checks passed
@dougthor42 dougthor42 deleted the dont-ignore-setup branch January 1, 2025 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gazelle incorrectly ignores files called setup.py.
2 participants