fix(pypi): change the parallelisation scheme for querying SimpleAPI #2531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of querying everything in parallel and yielding a lot of 404 warnings, let's query the main index first and then query the other indexes only for the packages that were not yet found. This should make the problem in bazelbuild#2100 not as serious. What is more, we can print the value of for the users to use. Work towards bazelbuild#2100
|
@dougthor42, if the CI passes, could you give this a spin please? FYI @ewianda, this may slow down the fetching, but only if you are not using |
|
Seems to work well for me! I didn't see any unintended side effects. Note that we already use |
rickeylev
approved these changes
Dec 27, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of querying everything in parallel and yielding a lot of 404
warnings, let's query the main index first and then query the other
indexes only for the packages that were not yet found.
What is more, we can print the value of
experimental_index_url_overridesfor the users to use.
Whilst at it, add a unit test to check the new logic.
Fixes #2100, since this is the best
rules_pythoncan do for now.