-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Update doublestar to a version that works with the latest Gazelle #2480
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI @dougthor42.
I ran this locally and didn't see any issues 🎉. The previous comments still need to be addressed though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a whitespace nit but otherwise LGTM. When that's fixed I'll give the 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@aignas @rickeylev I'm not yet super familiar with the CI pipeline, so I'm not sure if that buildkite failure is a blocker or not, or if it's just a flake. |
I think this was just a flaky run: could not download Bazel: failed to download bazel: failed to download bazel:. If someone with BuildKite permissions is around, there's a "retry" button, which will allow that one build to be retried. |
No description provided.