cc_helper: add functions related to coverage #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malt3
requested review from
trybka,
armandomontanez,
pzembrod,
comius and
c-mita
as code owners
malt3
force-pushed
the
mp/rules_cc_helper_coverage
branch
from
03d4047 to
a53c30a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a possible solution to bazelbuild/bazel#24724.
I think it is minimally invasive, because it avoids having to make
compilation_outputs.gcno_files()andcompilation_outputs.pic_gcno_files()public APIs.Instead, rules_cc takes over another helper and internally handles forwarding of gcno files.
The failing test
//tests/system_library:system_library_testis failing on main as well.