Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix soplex deps; add boost dependency; add cc_binary target #3515

Merged
merged 8 commits into from
Jan 2, 2025
Merged

fix soplex deps; add boost dependency; add cc_binary target #3515

merged 8 commits into from
Jan 2, 2025

Conversation

lperron
Copy link
Contributor

@lperron lperron commented Jan 1, 2025

Fix soplex:

  • move zstr as a deps as it leaks on the client build file otherwise (not an issue as it is a header only library)
  • add missing multiprecision option
  • add cc_binary rule to build the soplex binary (and verify the compilation went well)

@bazel-io
Copy link
Member

bazel-io commented Jan 1, 2025

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (soplex) have been updated in this PR. Please review the changes.

@fmeum fmeum added the skip-url-stability-check Skip the URL stability check for the PR label Jan 1, 2025
@fmeum fmeum added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Jan 2, 2025
@fmeum fmeum merged commit cb2ab76 into bazelbuild:main Jan 2, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmeum fmeum fmeum approved these changes

Assignees
No one assigned
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lperron @bazel-io @fmeum