Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lanelet2 module #3494

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Add lanelet2 module #3494

wants to merge 10 commits into from
+398 −0

Conversation

kgreenek
Copy link
Contributor

Closes #3487

@bazel-io
Copy link
Member

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (lanelet2) have been updated in this PR. Please review the changes.

@wep21
Copy link
Contributor

wep21 commented Dec 26, 2024

needs presubmit.yml?

@kgreenek
Copy link
Contributor Author

needs presubmit.yml?

Doh I was in too much of a rush this morning! Added

@kgreenek
Copy link
Contributor Author

@bazel-io skip_check unstable_url

@bazel-io bazel-io added the skip-url-stability-check Skip the URL stability check for the PR label Dec 26, 2024
@kgreenek
Copy link
Contributor Author

PTAL

Sorry for the noise

@wep21
Copy link
Contributor

wep21 commented Dec 27, 2024

@fmeum @meteorcloudy please add presubmit auto run

@fmeum fmeum added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Dec 27, 2024
fmeum
fmeum previously approved these changes Dec 27, 2024
View reviewed changes
@fmeum
Copy link
Contributor

fmeum commented Dec 27, 2024

Checks are falling

@wep21
Copy link
Contributor

wep21 commented Dec 27, 2024

please update geographiclib after #3495 is merged.

@kgreenek
Copy link
Contributor Author

The test errors are tough to debug because I can't reproduce here locally. On my machine and my CI the tests pass.

Is it possible for me to see the .bazelrc that is being used in these CI checks?

@bazel-io bazel-io dismissed fmeum’s stale review December 27, 2024 14:35

Require module maintainers' approval for newly pushed changes.

@kgreenek
Copy link
Contributor Author

Nevermind! I figured it out. I needed to pass the c++17 args in my presubmit.yml

@kgreenek
Copy link
Contributor Author

This is just waiting until the geographiclib fix is merged to main now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmeum fmeum fmeum left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wanted: lanelet2
4 participants
@kgreenek @bazel-io @wep21 @fmeum