Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated rules_req_compile repository location #3297

Closed
wants to merge 1 commit into from

Conversation

abrisco
Copy link

@abrisco abrisco commented Dec 2, 2024

Addresses the rules_req_compile issue on #3260

Copy link

google-cla bot commented Dec 2, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@bazel-io
Copy link
Member

bazel-io commented Dec 2, 2024

Hello @sputt, modules you maintain (rules_req_compile) have been updated in this PR. Please review the changes.

sputt
sputt previously approved these changes Dec 2, 2024
bazel-io
bazel-io previously approved these changes Dec 2, 2024
Copy link
Member

@bazel-io bazel-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @bazelbuild/bcr-maintainers, all modules in this PR have been approved by their maintainers. Please take a final look to merge this PR.

@fmeum fmeum added the USE-WITH-CAUTION-skip-modification-check Allow modifying checked-in modules, reproducible dependency resolution should not be compromised label Dec 2, 2024
@fmeum
Copy link
Contributor

fmeum commented Dec 2, 2024

@abrisco Could you sign the CLA?

@bazel-io bazel-io dismissed stale reviews from sputt and themself December 2, 2024 18:17

Require module maintainers' approval for newly pushed changes.

@abrisco abrisco closed this Dec 2, 2024
@abrisco
Copy link
Author

abrisco commented Dec 2, 2024

replaced by #3300

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
USE-WITH-CAUTION-skip-modification-check Allow modifying checked-in modules, reproducible dependency resolution should not be compromised
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants