Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add [email protected] #3058

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

mattyclarkson
Copy link
Contributor

Supports edge-cases in Bazel 8+.

Once this lands. I can roll this through modules that depend on this, such as ape.

Supports edge-cases in Bazel 8+
@mattyclarkson
Copy link
Contributor Author

mattyclarkson commented Oct 30, 2024

Needed to correctly support Bazel 8+. Will be used to roll out to modules depending on it such as ape. Will eventually help to resolve #3056. @meteorcloudy if you could give this presubmit I can get on fixing the other modules 😄

@meteorcloudy meteorcloudy added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Oct 30, 2024
Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@meteorcloudy meteorcloudy merged commit 01aca64 into bazelbuild:main Oct 30, 2024
21 checks passed
@mattyclarkson mattyclarkson deleted the toolchain_utils branch October 30, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants