Merged
[email protected] #2413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![publish-to-bcr-bot[bot]](https://avatars.githubusercontent.com/in/234555?s=60&v=4){kind=small}
|
Hello @zhangskz, @mkruskal-google, @googleberg, modules you maintain (protobuf) have been updated in this PR. Please review the changes. |
zhangskz
previously approved these changes
Jul 12, 2024
Wyverald
added
the
presubmit-auto-run
bazel-io
previously approved these changes
Jul 12, 2024
|
CI is failing |
bazel-io
dismissed stale reviews from zhangskz and themself
Require module maintainers' approval for newly pushed changes.
zhangskz
force-pushed
the
protocolbuffers/[email protected]
branch
from
e3db9de to
8f0df53
Compare
zhangskz
previously approved these changes
Jul 16, 2024
bazel-io
previously approved these changes
Jul 16, 2024
|
@zhangskz CI is still failing on Bazel 6 |
|
Thanks, will likely remove the rust presubmit entirely for now as the failing target is not actually intended for release / widespread use yet (and we are thus missing the equivalent test coverage in our repo). Will update this PR shortly once the equivalent change is made to protobuf repo. |
Rust protobuf is in development and not intended for use / released yet. We should add this back at some point when rust is ready for release, after adding equivalent GHA presubmit tests.
zhangskz
force-pushed
the
protocolbuffers/[email protected]
branch
from
8f0df53 to
686f5ea
Compare
bazel-io
dismissed stale reviews from zhangskz and themself
Require module maintainers' approval for newly pushed changes.
zhangskz
approved these changes
Jul 17, 2024
bazel-io
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release: https://github.com/protocolbuffers/protobuf/releases/tag/v28.0-rc1
Automated by Publish to BCR